Fix PCI Stripe e anteprima regia; checkout sempre hosted.

Blocca l'invio di numeri carta dall'API server, usa Checkout anche per i cambi piano e nasconde correttamente il placeholder video in regia.

Co-authored-by: Cursor <cursoragent@cursor.com>

backend/app/services/billing/stripe/checkout_session.rb

@@ -18,15 +18,29 @@ module Billing
         raise "Price ID Stripe mancante per #{@plan_slug}" if price_id.blank?
 
         customer_id = ensure_customer_id!
-        session = ::Stripe::Checkout::Session.create(
+        CustomerSync.call(club: @club, customer_id: customer_id)
+
+        session_params = {
           mode: "subscription",
           customer: customer_id,
           line_items: [{ price: price_id, quantity: 1 }],
           success_url: success_url,
           cancel_url: cancel_url,
           metadata: { club_id: @club.id, user_id: @user.id, plan_slug: @plan_slug },
-          subscription_data: { metadata: { club_id: @club.id, plan_slug: @plan_slug } }
-        )
+          subscription_data: { metadata: { club_id: @club.id, plan_slug: @plan_slug } },
+          billing_address_collection: "required",
+          customer_update: { address: "auto", name: "auto" },
+          allow_promotion_codes: true
+        }
+
+        existing_subscription_id = active_stripe_subscription_id
+        if existing_subscription_id.present?
+          # Cambio piano: conferma su pagina Stripe (mai dati carta sul nostro server).
+          session_params[:subscription] = existing_subscription_id
+          session_params.delete(:subscription_data)
+        end
+
+        session = ::Stripe::Checkout::Session.create(session_params)
         session.url
       end
 
@@ -34,9 +48,10 @@ module Billing
         raise "Stripe non configurato" unless MatchLiveTv.stripe_enabled?
 
         customer_id = ensure_customer_id!
+        CustomerSync.call(club: @club, customer_id: customer_id)
         session = ::Stripe::BillingPortal::Session.create(
           customer: customer_id,
-          return_url: dashboard_url
+          return_url: billing_url
         )
         session.url
       end
@@ -50,13 +65,20 @@ module Billing
         end
       end
 
+      def active_stripe_subscription_id
+        sub = @club.subscription
+        return nil unless sub&.stripe_subscription_id.present? && sub.active?
+
+        sub.stripe_subscription_id
+      end
+
       def ensure_customer_id!
         sub = @club.subscription || @club.build_subscription(plan: Plan["free"], status: "active")
         return sub.stripe_customer_id if sub.stripe_customer_id.present?
 
         customer = ::Stripe::Customer.create(
           email: @user.email,
-          name: @club.name,
+          name: @club.billing_legal_name.presence || @club.name,
           metadata: { club_id: @club.id }
         )
         sub.update!(stripe_customer_id: customer.id)
@@ -74,10 +96,6 @@ module Billing
       def billing_url
         "#{MatchLiveTv.app_public_url.chomp('/')}/clubs/#{@club.id}/billing"
       end
-
-      def dashboard_url
-        "#{MatchLiveTv.app_public_url.chomp('/')}/clubs/#{@club.id}"
-      end
     end
   end
 end