Rafforza i requisiti password con regole di complessità di mercato.

Co-authored-by: Cursor <cursoragent@cursor.com>

backend/spec/models/password_complexity_spec.rb

@@ -0,0 +1,36 @@
+require "rails_helper"
+
+RSpec.describe PasswordComplexity do
+  describe ".violation" do
+    it "accepts a password with 3 character classes" do
+      expect(described_class.violation("NewPass123")).to be_nil
+    end
+
+    it "accepts symbols instead of one letter class" do
+      expect(described_class.violation("newpass1!")).to be_nil
+    end
+
+    it "rejects passwords that are too short" do
+      expect(described_class.violation("Ab1!")).to eq(:too_short)
+    end
+
+    it "rejects passwords with fewer than 3 classes" do
+      expect(described_class.violation("password123")).to eq(:too_weak)
+      expect(described_class.violation("PASSWORD123")).to eq(:too_weak)
+      expect(described_class.violation("Password")).to eq(:too_weak)
+    end
+  end
+
+  describe "User validation" do
+    it "blocks weak passwords on create" do
+      user = User.new(email: "weak@example.com", name: "Weak", password: "password123", role: "coach")
+      expect(user).not_to be_valid
+      expect(user.errors[:password]).to be_present
+    end
+
+    it "allows strong passwords on create" do
+      user = User.new(email: "strong@example.com", name: "Strong", password: "NewPass123", role: "coach")
+      expect(user).to be_valid
+    end
+  end
+end

backend/spec/requests/account_spec.rb

@@ -1,9 +1,9 @@
 require "rails_helper"
 
 RSpec.describe "Account API", type: :request do
-  let!(:user) { User.create!(email: "account@example.com", name: "Account User", password: "password123", role: "coach") }
+  let!(:user) { User.create!(email: "account@example.com", name: "Account User", password: "Password123", role: "coach") }
   let(:auth_headers) do
-    post "/api/v1/auth/login", params: { email: user.email, password: "password123" }
+    post "/api/v1/auth/login", params: { email: user.email, password: "Password123" }
     token = JSON.parse(response.body).fetch("access_token")
     { "Authorization" => "Bearer #{token}" }
   end
@@ -40,25 +40,38 @@ RSpec.describe "Account API", type: :request do
     it "changes the password with the current password" do
       patch "/api/v1/account/password",
             params: {
-              current_password: "password123",
-              password: "newpass123",
-              password_confirmation: "newpass123"
+              current_password: "Password123",
+              password: "NewPass123",
+              password_confirmation: "NewPass123"
             },
             headers: auth_headers
       expect(response).to have_http_status(:ok)
-      expect(user.reload.authenticate("newpass123")).to be_truthy
+      expect(user.reload.authenticate("NewPass123")).to be_truthy
     end
 
     it "rejects an incorrect current password" do
       patch "/api/v1/account/password",
             params: {
               current_password: "wrong",
+              password: "NewPass123",
+              password_confirmation: "NewPass123"
+            },
+            headers: auth_headers
+      expect(response).to have_http_status(:unprocessable_entity)
+      expect(user.reload.authenticate("Password123")).to be_truthy
+    end
+
+    it "rejects a password that fails complexity rules" do
+      patch "/api/v1/account/password",
+            params: {
+              current_password: "Password123",
               password: "newpass123",
               password_confirmation: "newpass123"
             },
             headers: auth_headers
       expect(response).to have_http_status(:unprocessable_entity)
-      expect(user.reload.authenticate("password123")).to be_truthy
+      expect(JSON.parse(response.body)["error"]).to match(/3 of/i)
+      expect(user.reload.authenticate("Password123")).to be_truthy
     end
   end
 

backend/spec/requests/auth_spec.rb

@@ -1,10 +1,10 @@
 require "rails_helper"
 
 RSpec.describe "Auth API", type: :request do
-  let!(:user) { User.create!(email: "test@example.com", name: "Test", password: "password123", role: "coach") }
+  let!(:user) { User.create!(email: "test@example.com", name: "Test", password: "Password123", role: "coach") }
 
   it "logs in with valid credentials" do
-    post "/api/v1/auth/login", params: { email: user.email, password: "password123" }
+    post "/api/v1/auth/login", params: { email: user.email, password: "Password123" }
     expect(response).to have_http_status(:ok)
     expect(JSON.parse(response.body)).to have_key("access_token")
   end